chrono: Resolve TODOs related to C++20 chrono feats#2016
Merged
Conversation
|
Build size and comparison to main:
|
JF002
approved these changes
Mar 14, 2024
Collaborator
JF002
left a comment
JF002
left a comment
There was a problem hiding this comment.
LGTM!
[...] but not supported by GCC 10 it seems.
We might want to update our version of GCC to fix those issues and benefit from more recent compiler :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple more TODOs related to using
std::chrono::year, which was added in C++20, but not supported by GCC 10 it seems.