You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces a validation on the Destination attribute value, in Response.
Destination value MUST be present if binding is HTTP-REDIRECT or HTTP-POST, and correctly valued
peppelinux
changed the title
fix: Destination missing or unvalued. Fixes: https://github.com/IdentityPython/pysaml2/issues/770
fix: Destination missing or unvalued
Mar 20, 2021
c00kiemon5ter
changed the title
fix: Destination missing or unvalued
Validate Destination
Apr 6, 2021
What I see is that the Destination attribute is optional, verified by the schema
Destination [Optional]
A URI reference indicating the address to which this request has been sent. This is useful to prevent
malicious forwarding of requests to unintended recipients, a protection that is required by some
protocol bindings. If it is present, the actual recipient MUST check that the URI reference identifies
the location at which the message was received. If it does not, the request MUST be discarded.
Some protocol bindings may require the use of this attribute (see [SAMLBind]).
@c00kiemon5ter Ok, I believe that this PR can be reopened following the reason that the Destination MAY be omitted, because it's optional, BUT if present it MUST be validated upon a match on valid ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a validation on the Destination attribute value, in Response.
Destination value MUST be present if binding is HTTP-REDIRECT or HTTP-POST, and correctly valued
fixes: #770
All Submissions: