Add config option for specifying SignatureMethod/DigestMethod#396
Closed
joetsoi wants to merge 2 commits intoIdentityPython:masterfrom
Closed
Add config option for specifying SignatureMethod/DigestMethod#396joetsoi wants to merge 2 commits intoIdentityPython:masterfrom
joetsoi wants to merge 2 commits intoIdentityPython:masterfrom
Conversation
If `sign_alg` or `digest_alg` is not provided as a parameter to Saml2Client.sign(), then check if one has been provided in the config before falling back to `sig_default` in xmldsig.
6 tasks
Member
|
continue this on #597 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice if you were able to specify a default signing or digest method, instead of having to specify it as a parameter to Entity/Saml2Client.sign() and just be able to specify in an sp's config which signing algorithm it is using.
Is there a better method of doing this already in the config that I've missed?
Adds signing_algorithm and digest_algorithm to Entity.
If
sign_algordigest_algis not provided as a parameter toSaml2Client.sign(), then check if one has been provided in the config
before falling back to
sig_defaultin xmldsig.