fix: Produce MAG L1c without Normal mode data#2274
Merged
maxinelasp merged 25 commits intoIMAP-Science-Operations-Center:devfrom Oct 10, 2025
Merged
fix: Produce MAG L1c without Normal mode data#2274maxinelasp merged 25 commits intoIMAP-Science-Operations-Center:devfrom
maxinelasp merged 25 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
maxinelasp
reviewed
Oct 3, 2025
Contributor
maxinelasp
left a comment
maxinelasp
left a comment
There was a problem hiding this comment.
Overall looks good, just a few suggested changes. Thank you!!
Co-authored-by: Maxine Hartnett <117409426+maxinelasp@users.noreply.github.com>
…llegeLondon/imap_processing into fix/mag-l1c-no-normal
maxinelasp
reviewed
Oct 7, 2025
Contributor
|
@all-contributors please add @mfacchinelli for code, test |
Contributor
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token { in JSON at position 4042 |
Contributor
|
@all-contributors please add @mfacchinelli for code, test |
Contributor
|
I've put up a pull request to add @mfacchinelli! 🎉 |
Collaborator
Author
Thanks Maxine! |
maxinelasp
approved these changes
Oct 9, 2025
Contributor
maxinelasp
left a comment
maxinelasp
left a comment
There was a problem hiding this comment.
Looks good! Let me know when you're ready to merge and I can merge it for you @mfacchinelli
Collaborator
Author
Thanks Maxine, ready to merge! |
maxinelasp
merged commit f12e361
into
IMAP-Science-Operations-Center:dev
14 checks passed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Adds support for generating MAG L1c files even when no input Normal mode data is provided.
New Dependencies
N/A
New Files
Only new test data files.
Deleted Files
N/A
Updated Files
imap_processing/mag/l1c/mag_l1c.py:None. Reuses existing functionality to downsample the whole day +/- 30 minutes, without checking Normal mode for gaps (the whole day is the gap).Testing
test_missing_norm_fileinimap_processing/tests/mag/test_mag_l1c.py