Skip to content
This repository was archived by the owner on Oct 29, 2025. It is now read-only.

Added pxhd injection and validaiton#68

Merged
yaronschwimmer merged 18 commits into
devfrom
dev-add-pxhd
Jan 2, 2019
Merged

Added pxhd injection and validaiton#68
yaronschwimmer merged 18 commits into
devfrom
dev-add-pxhd

Conversation

@alexbpx

@alexbpx alexbpx commented Nov 5, 2018

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread lib/pxutil.js Outdated
Comment thread lib/pxutil.js Outdated
Comment thread lib/pxutil.js Outdated
Comment thread lib/pxutil.js Outdated
Comment thread lib/pxutil.js Outdated
if (config.ENRICH_CUSTOM_PARAMETERS) {
const enrichedCustomParams = config.ENRICH_CUSTOM_PARAMETERS(customParams);
for (const param in enrichedCustomParams) {
if ((param.match(/^custom_param\d$/) || param.match(/^custom_param10$/)) && enrichedCustomParams[param] !== '') {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ((param.match(/^custom_param\d$/) || param.match(/^custom_param10$/)) && enrichedCustomParams[param] !== '') {
if (param.match(/^custom_param([1-9]|10)$/) && enrichedCustomParams[param] !== '') {

@yaronschwimmer yaronschwimmer merged commit 86ad3e1 into dev Jan 2, 2019
@yaronschwimmer yaronschwimmer deleted the dev-add-pxhd branch January 2, 2019 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants