Remove Guava dependency with no direct use in codebase#1213
Closed
magdel wants to merge 1 commit intoHubSpot:masterfrom
magdel:feature/remove-guava-dependency
Closed
Remove Guava dependency with no direct use in codebase#1213magdel wants to merge 1 commit intoHubSpot:masterfrom magdel:feature/remove-guava-dependency
magdel wants to merge 1 commit intoHubSpot:masterfrom
magdel:feature/remove-guava-dependency
Conversation
thadguidry
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
LGTM, and compiles successful. mvn dependency:tree shows no issues.
Looks like Guava is indeed still needed, at least for JinjavaConfig
Caused by: java.lang.NoClassDefFoundError: com/google/common/collect/ImmutableSet
at com.hubspot.jinjava.JinjavaConfig$Builder.(JinjavaConfig.java:327)
thadguidry
suggested changes
Nov 25, 2024
thadguidry
left a comment
thadguidry
left a comment
There was a problem hiding this comment.
Guava is still needed it seems currently, at least for JinjavaConfig
Author
|
@thadguidry thank you. Now I see it comes from other dependencies like Removing its now I see how much it is used. And with language level 8 Guava is hardly replaceble |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found no direct use of Guava library in library codebase. Why should we have it in dependencies? Use the jininja often clashes with project`s Guava library version.