Enhance OCL job resilience with comprehensive failure handling#166
Merged
grahamegrieve merged 3 commits intomainfrom Mar 12, 2026
Merged
Enhance OCL job resilience with comprehensive failure handling#166grahamegrieve merged 3 commits intomainfrom
grahamegrieve merged 3 commits intomainfrom
Conversation
…xx, hang, malformed payload) are handled safely; jobs always release resources; regression tests ensure queue recovery, no deadlock, and no unhandled rejection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new test suite for the OCL background job queue, focusing on its resilience to various API failure scenarios, and strengthens the code to better handle malformed API responses. The most important changes are grouped below:
Testing OCL Background Job Resilience:
ocl-background-resilience.test.js) that simulates various OCL API failure scenarios (connection refused, timeouts, repeated HTTP 500 errors, malformed payloads, and sequential failures) to ensure that theOCLBackgroundJobQueuehandles these failures gracefully and does not get blocked.Robustness Improvements:
#fetchAllPagesmethod inOCLCodeSystemProviderto explicitly check that API responses are objects or arrays, throwing an error if the response format is invalid. This prevents malformed payloads from being silently accepted.