Different improvements and fixes#12
Merged
Merged
Conversation
romamik
commented
Jun 27, 2016
romamik
commented
Contributor
- Changed default host to 0.0.0.0 - to listen on all interfaces.
- Added HXML to run server (it's windows specfic: i've added 'start' to open neko in new window, because haxe with -cmd do not allow to read input for invoked program)
- Fixed printing fields of TObjects - name of the field was not printed
- Fixed class printing - it was never called
- Fixed static fields printing - they were always printed as NULL.
…t is possible to use HaxeServer with another controllers
…eturning false. 2. Fixed static fields printing: Reflect.getProperty should be on class to get static field.
bji
reviewed
Sep 27, 2016
bji
left a comment
bji
left a comment
Contributor
There was a problem hiding this comment.
These changes use tabs for indentation, which is contrary to the coding style in this file (and also contrary to common sense). I will fix the indentation in a subsequent commit.
Contributor
Author
|
Glad to see somebody is looking after this repository. I just did not noticed that tab/spaces difference, it was not visible in my editor... Sorry for that. |
Contributor
|
No problem. Happens to me sometimes too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.