Skip to content

add descriptive todo for death crash #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kenix3 merged 1 commit into from
Jul 12, 2022
Merged

add descriptive todo for death crash #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion soh/src/code/z_lights.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,9 @@ void Lights_BindAll(Lights* lights, LightNode* listHead, Vec3f* vec) {

while (listHead != NULL) {
info = listHead->info;
if (info->type < 3) { // bandaid fix for death crash issue
// OTRTODO: we do not know the root cause of the info->type value being invalid
// but this prevents it from crashing the game on the game over screen
if (info->type < 3) {
bindFuncs[info->type](lights, &info->params, vec);
}
listHead = listHead->next;
Expand Down