Skip to content

[Mod]Enable 3D Projectiles for monsters - #413

Merged
Kenix3 merged 7 commits into
HarbourMasters:developfrom
Baoulettes:3DProjectiles
Jun 22, 2022
Merged

[Mod]Enable 3D Projectiles for monsters#413
Kenix3 merged 7 commits into
HarbourMasters:developfrom
Baoulettes:3DProjectiles

Conversation

@Baoulettes

Copy link
Copy Markdown
Contributor

This mod add a toggle to turn on/off 3D Projectiles for Octorok and all Scrubs.
Should have been called UnoRok
And this one the sniper

@MelonSpeedruns

MelonSpeedruns commented May 25, 2022

Copy link
Copy Markdown
Contributor

Should probably use the same Cvar as "Enable 3D Dropped items", which the label for it should be renamed to "Enable 3D Dropped Items/Projectiles". Otherwise, good job! :D

@Baoulettes

Copy link
Copy Markdown
Contributor Author

Should probably use the same Cvar as "Enable 3D Dropped items", which the label for it should be renamed to "Enable 3D Dropped Items/Projectiles". Otherwise, good job! :D

Should be okay now and thank you :)
I plan to add more when I find a way to make Bombs flash ~

@MelonSpeedruns MelonSpeedruns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PurpleHato PurpleHato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost

ghost commented May 28, 2022

Copy link
Copy Markdown

Nice one!! It would be awesome to make the bombs Link uses 3d as well!!

@PurpleHato

Copy link
Copy Markdown
Member

Nice one!! It would be awesome to make the bombs Link uses 3d as well!!

The main issue that prevent this to happening for now is to make the bomb flashing colours since functions like "Link being hurt" and such doesn't work on those

@outerwinnie

Copy link
Copy Markdown

When you enable this, you can't deflect Scrubs proyectiles, so you can't complete the Deku Tree.

@Baoulettes

Copy link
Copy Markdown
Contributor Author

let me check again and I will see for me it worked but I will check again I may have failed

@Baoulettes

Copy link
Copy Markdown
Contributor Author

When you enable this, you can't deflect Scrubs proyectiles, so you can't complete the Deku Tree.

Should be fixed now :)

@outerwinnie

Copy link
Copy Markdown

When you enable this, you can't deflect Scrubs proyectiles, so you can't complete the Deku Tree.

Should be fixed now :)

Yup, tested and perfectly working now. Thanks!

Comment thread soh/src/overlays/actors/ovl_En_Okuta/z_en_okuta.c Outdated

@NEstelami NEstelami left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kenix3

Kenix3 commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

Merge pending conflict resolution.

Baoulettes and others added 2 commits June 20, 2022 22:32
Thanks I overlooked it :)

Co-authored-by: BountyChocolate123456 <101743444+BountyChocolate123456@users.noreply.github.com>
@Baoulettes

Copy link
Copy Markdown
Contributor Author

conflict fixed, suggestions commit (one cvar check had wrong cvar check thanks :) )

@Kenix3
Kenix3 merged commit 77fc202 into HarbourMasters:develop Jun 22, 2022
@Baoulettes
Baoulettes deleted the 3DProjectiles branch July 6, 2022 00:54
Kenix3 added a commit to Kenix3/Shipwright that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants