Improve Controller LED Control - #2864
Merged
leggettc18 merged 26 commits intoMay 28, 2023
Merged
Conversation
…he switch statements to lessen potential computational load.
…" button under Settings -> Controller. Renamed "Controller Configuration" to "Configure Controller" and "Customize Game Controls" to "Customize In-game Controls"
Moved controller LED brightness to new LED Colors group in "Customize In-game Controls" menu. Added combobox to choose between vanilla tunics, cosmetics tunics, health, and custom as color sources. Added critical health override checkbox to allow display of red when health is low even when other sources are selected. Port color pickers have not been implemented yet, default color is white.
…to `CanSetLed()`.
… application of colors in `OTRControllerCallback` to port 1.
Added custom color picker to port 1 color settings.
Malkierian
marked this pull request as ready for review
May 10, 2023 19:32
…,0} when brightness is off.
…t into ps-lightbar-updates
briaguya0
reviewed
May 18, 2023
briaguya0
left a comment
briaguya0
left a comment
Contributor
There was a problem hiding this comment.
overall this is looking great. left a couple suggestions in there but nothing huge. i'm also not able to test this so it'd be ideal for someone who can to review/approve
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Contributor
Author
|
Archez has tested this before and confirmed it all works as expected. |
idea for cleaning up controller callback stuff
…ed regardless of other settings.
leggettc18
approved these changes
May 28, 2023
leggettc18
left a comment
leggettc18
left a comment
Contributor
There was a problem hiding this comment.
Don't have the controllers to test this with but I remember others testing this and saying it worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding extra controls for controller LED functionality. Currently applies to port 1 controller only.
Adds brightness slider. 0% turns off
Adds four options for color source: original tunic colors, current cosmetics tunic colors, health-based, and custom, with color picker.
Prevents options from showing and calculations for LED change function from occurring if port 1 doesn't support setting the LED color.
Build Artifacts