Support for allocating more sketches than normal#133
Merged
Conversation
Victor-C-Zhang
previously requested changes
Jul 16, 2023
include/graph_configuration.h
Outdated
| // Ex factor of 1, double the sketches | ||
| // factor of 0.5, 1.5 times the sketches | ||
| // factor of 0, normal quantity of sketches | ||
| double _adtl_skts_factor = 0; |
Collaborator
There was a problem hiding this comment.
my engineer brain dislikes this very much. would be simpler for it to be just multiplicative and name it accordingly
Collaborator
Author
There was a problem hiding this comment.
Hmm okay I suppose that works at well.
Collaborator
|
pls also document the changes you made to memory profiling/etc |
Collaborator
Author
What changes are you referring to exactly? |
Gillgamesh
approved these changes
Jul 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to, for a variety of potential applications, be able to allocate more than just O(log n) sketches. This pull request gives that option to users through the
graph_configuration.