Merged
Conversation
Changes to support stream api improvements
Collaborator
Author
|
I added a benchmark that tests the performance of DSU merging/joining and compared the results of that benchmark with this DSU design and that of our previous implementation. This test is actually two benchmarks. The first |
Collaborator
Author
|
Now that we have confirmation that this new design isn't a performance detriment, I'd like to get these changes merged. |
kennyzzhang
requested changes
Feb 8, 2023
Collaborator
kennyzzhang
left a comment
There was a problem hiding this comment.
A few small changes
DanielDeLayo
approved these changes
Feb 8, 2023
kennyzzhang
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSU updates to use path halving
Serialized size getters for Supernode and Sketch