GraphQL v3#147
Merged
paulofaria merged 12 commits intoDec 14, 2024
Merged
Conversation
paulofaria
previously approved these changes
Nov 1, 2024
paulofaria
left a comment
paulofaria
left a comment
Member
There was a problem hiding this comment.
Awesome work!!! Since this is a major bump, I think it would be nice to highlight the new features in the README.
This was typically used to override a resolver type into a TypeReference. With TypeReference no longer necessary, allowing this simply reduces type safety.
NeedleInAJayStack
force-pushed
the
feat/graphql-sdl
branch
from
294454c to
1f35674
Compare
Member
Author
|
Sorry Paulo - I should have drafted this one. I've added a migration guide, and deleted deprecated features. I still have a little validation testing to do before I want to call this ready. |
Member
Author
|
Ok, my validation is complete - sorry about the delay. Since your last review @paulofaria, I added a migration guide, similar to what we did for the GraphQL repo. Let me know if that addresses your thoughts! Thanks! |
Member
Author
|
@paulofaria Just a ping on this! |
|
Any idea when this might get a release? |
paulofaria
approved these changes
Dec 14, 2024
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds compatibility with GraphQL v3.0.0, and removes
TypeReferencesince it is no longer necessary.This will result in a major version bump.