Skip to content

Made inits public for NoArguments and PageInfo#126

Merged
NeedleInAJayStack merged 3 commits into
GraphQLSwift:mainfrom
cshadek:public_no_arguments
Oct 25, 2023
Merged

Made inits public for NoArguments and PageInfo#126
NeedleInAJayStack merged 3 commits into
GraphQLSwift:mainfrom
cshadek:public_no_arguments

Conversation

@cshadek

@cshadek cshadek commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

Addresses #124 to make inits public for both PageInfo and NoArguments. This should help with custom connections and enable people to call resolvers with no arguments directly.

@cshadek

cshadek commented Oct 13, 2023

Copy link
Copy Markdown
Contributor Author

@NeedleInAJayStack I don't know why macOS is failing, but I also fixed swiftformat warnings in ConnectionTests. The only real changes I made are making the inits public.

@NeedleInAJayStack NeedleInAJayStack self-requested a review October 14, 2023 18:15

@NeedleInAJayStack NeedleInAJayStack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @cshadek!

It appears that the MacOS failure is related to codeclimate: https://github.com/GraphQLSwift/Graphiti/actions/runs/6512886544/job/17691405715?pr=126#step:4:7956
@paulofaria, do you have any insight or would you prefer if we disable the codeclimate integration?

@cshadek

cshadek commented Oct 21, 2023

Copy link
Copy Markdown
Contributor Author

@NeedleInAJayStack, @paulofaria is it possible to approve this merge even with macOS failing?

@paulofaria

Copy link
Copy Markdown
Member

Is codeclimate still being used for test coverage? I don't remember if test coverage checks are required by the SSWG maturity level we're going for?

@cshadek

cshadek commented Oct 25, 2023

Copy link
Copy Markdown
Contributor Author

Is it possible to expedite this? We are trying to have custom connections in addition to the graffiti ones, and both need access to PageInfo. We use other libraries (Pioneer, PioneerRedisPubsub, etc), using the forked version seems to cause errors because both Pioneer and our other package are using the same identifier for different repos.

@NeedleInAJayStack

Copy link
Copy Markdown
Member

@cshadek Sure, we can merge this in since the CI shows that no tests are failing on MacOS. If you have any free cycles, we'd sure love some help either fixing the codeclimate CI or finding a different test coverage solution (I've been super slammed with other things recently). But yeah, don't want it to hold you up in the meantime.

@NeedleInAJayStack NeedleInAJayStack merged commit 09b3c37 into GraphQLSwift:main Oct 25, 2023
@cshadek

cshadek commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

@NeedleInAJayStack Thanks! I'll look into it. Not too familiar with codeclimate, but I'll see what I can do!

@cshadek cshadek deleted the public_no_arguments branch December 1, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants