Skip to content

Connections - Adds tests and documentation#108

Merged
NeedleInAJayStack merged 2 commits into
GraphQLSwift:mainfrom
NeedleInAJayStack:test/connections
Mar 13, 2023
Merged

Connections - Adds tests and documentation#108
NeedleInAJayStack merged 2 commits into
GraphQLSwift:mainfrom
NeedleInAJayStack:test/connections

Conversation

@NeedleInAJayStack

Copy link
Copy Markdown
Member

This adds tests and documentation to the Connection system, which should improve stability, maintainability, and adoption of this feature.

@cshadek

cshadek commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Should there be a test for when a connection is a field on a Type, or is that not needed?

@NeedleInAJayStack

Copy link
Copy Markdown
Member Author

@cshadek Yeah, I originally had them as object fields, but it made these tests pretty verbose. I've added one here
#109 where I fix the Connection aliasing issue you reported.

@d-exclaimation d-exclaimation left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants