Unwrap PropertiesDesign

[Goooler]

Refs #119.

[Copilot]

Pull request overview

Refactors the profile “Properties” flow to split the previous Design-based implementation into a Compose @Composable screen backed by a dedicated ViewModel (refs #119).

Changes:

• Added PropertiesViewModel to own UI state/events, validation, saving, and commit progress reporting.
• Reworked PropertiesScreen into a composable route that binds to PropertiesViewModel via collectAsStateWithLifecycle.
• Simplified PropertiesActivity to a Compose setContent host for PropertiesScreen and navigation callbacks.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
app/src/main/kotlin/com/github/kr328/clash/profile/vm/PropertiesViewModel.kt	New ViewModel providing state/events, autosave-on-stop, and commit/progress handling for the Properties UI.
app/src/main/kotlin/com/github/kr328/clash/profile/ui/PropertiesScreen.kt	Moves from Design to pure Compose; binds UI to PropertiesViewModel and forwards navigation/events.
app/src/main/kotlin/com/github/kr328/clash/profile/PropertiesActivity.kt	Converts to a lightweight Compose host activity wiring navigation callbacks and result handling.

Comments suppressed due to low confidence (1)

app/src/main/kotlin/com/github/kr328/clash/profile/ui/PropertiesScreen.kt:148

• ModelProgressBarState is mutated directly during composition via with(progressBarState) { ... }. Since its fields are mutableStateOf, writing them during composition can cause unnecessary recompositions and is inconsistent with existing patterns (e.g. LogcatScreen updates the progress state inside a LaunchedEffect). Consider moving these assignments into LaunchedEffect(progressState).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

onStop() auto-saves via patch(...) when there are unsaved changes, but the ViewModel never updates originalProfile / hasUnsavedChanges after a successful patch. This means the UI can continue to think there are unsaved changes and will re-patch on every subsequent stop. Consider updating originalProfile (and resetting hasUnsavedChanges) after the patch succeeds.

Suggested change

	withProfile { patch(profile.uuid, profile.name, profile.source, profile.interval) }
	withProfile { patch(profile.uuid, profile.name, profile.source, profile.interval) }
	}.onSuccess {
	uiState.update { state -> state.copy(originalProfile = profile.copy()) }

[Copilot]

GlobalScope.launch in onCleared() is the only GlobalScope usage in the app module and opts into DelicateCoroutinesApi. Prefer using the app-wide com.github.kr328.clash.common.Global scope (used elsewhere, e.g. Remote.kt) or another structured application scope so this work is still cancellable/traceable.

[Copilot]

The fallback error message uses a hard-coded string ("Unknown error"). The rest of the app uses the localized R.string.unknown (e.g. NewProfileViewModel.kt). Consider switching to that resource (or another localized string) for consistency and translation coverage.

Suggested change

	eventState.value = EventState.ShowMessage(e.message ?: "Unknown error")
	eventState.value =
	EventState.ShowMessage(
	e.message ?: getApplication<Application>().getString(R.string.unknown),
	)