cleanup: Upgrade Composer samples to Airflow 2.0#5782
Conversation
You are about to delete the following sample browser pages.
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
78a9ae2 to
7c60e1c
Compare
|
YAY #5806 made the tests pass!! This is only red because I'm bad at remembering to run lint locally!!!!!!!!!!!!! |
05cb6f9 to
f87bcac
Compare
|
Just looked at the dataflow/dataproc tutorials, LGTM! |
|
omg I have no idea how I made this mess with adding these requirements files. I'll fix later today 🤦🏻♀️ |
affa66f to
207371f
Compare
207371f to
f9447fa
Compare
|
I have been talking to TWs and need to move the Airflow 1 versions to a "legacy samples" folder |
|
Actually, I'll do the legacy samples thing in a separate PR. I'm ready for you, @dinagraves ! :) |
Description
This PR follows best practices for upgrading DAGs from Airflow 1 to Airflow 2. Changes included:
conftest.pyto theblogsfolder. For now, that DAG will stay at using Airflow 1.0, and we need to initialize a compatible DB for those tests separate from theworkflowsDB.workflows/requirements-test.txtcontribtoprovidersbash_operator->bash)If you would like access to my Composer environment to see the DAGs deployed, please let me know. Otherwise, here is a screenshot showing successful dag runs across the board
Fixes #5171
DataflowTemplateOperator tutorial update in CL/371792521 - removed instructions for setting
gce_regionAirflow variable (@sofisl )CHANGE NOT ADDRESSED - I need to look further at the DAG example we have triggered by GCF. That will be addressed in an upcoming PR.
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)