Skip to content

98_Design_doc_plot bounds#143

Closed
audreyyeoCH wants to merge 4 commits into
mainfrom
98_plotBounds
Closed

98_Design_doc_plot bounds#143
audreyyeoCH wants to merge 4 commits into
mainfrom
98_plotBounds

Conversation

@audreyyeoCH

Copy link
Copy Markdown
Collaborator

Design doc for issue #98

@audreyyeoCH audreyyeoCH self-assigned this Oct 10, 2025
@audreyyeoCH

audreyyeoCH commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator Author

Hi @danielinteractive , I started with a design doc even though there are no helper functions, so I can work on it piece by piece. I initially started without a design doc, hence I changed @params to @typed. Thanks for your review!

and this is an example :

coords <- boundsPredprob(
    looks = c(10, 20, 30, 40),
    p0 = 0.20,
    tT = 0.80,
    phiL = 0.10,
    phiU = 0.90,
  )
new_plotBounds(coords)
image

@github-actions

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                78       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              99       3  96.97%   32, 62, 154
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      174       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                97       9  90.72%   124-132
R/plotBounds.R              83      83  0.00%    43-131
R/plotDecision.R            73       0  100.00%
R/plotOc.R                  55       2  96.36%   99-100
R/postprob.R                34       1  97.06%   113
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                36       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumBetaDiff.R             80      15  81.25%   102-120
R/sumTable.R                36       0  100.00%
TOTAL                     2477     433  82.52%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  --------
R/plotBounds.R      +31     +31  +100.00%
TOTAL               +31     +31  -1.05%

Results for commit: 9c0c4d2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plotOc 💔 $208.48$ $+3.02$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
plotOc 💔 $102.32$ $+1.39$ plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status

Results for commit b76252f

♻️ This comment has been updated with latest results.

@danielinteractive danielinteractive left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , please see below

Comment thread R/plotBounds.R
Comment thread design/design_doc_plotBounds.qmd
Comment thread design/design_doc_plotBounds.qmd
@audreyyeoCH

Copy link
Copy Markdown
Collaborator Author

closing this PR as renaming local branch created new origin, fyi @danielinteractive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants