Patch: Rod constructor warning messages#71
Merged
skim0119 merged 5 commits intoApr 28, 2022
Conversation
The logging level of some messages are lowered (warning->info) in order to avoid unnecessary logging.
209d3c1 to
a06ac63
Compare
e38e936 to
6b9dc8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poisson_ratioandshear_modulusare given. In this case, a warning should saypoisson_ratiowill be ignored.logwhat happened. I don't think it is necessary to throw a warning.kwargslowers readability.allocate