Update on constraint module; Add generalized constraint class#56
Merged
Conversation
b0d8b70 to
c0576ce
Compare
c0576ce to
88b395a
Compare
Codecov Report
@@ Coverage Diff @@
## update-0.2.2 #56 +/- ##
================================================
+ Coverage 81.26% 81.70% +0.43%
================================================
Files 40 40
Lines 2552 2645 +93
Branches 357 372 +15
================================================
+ Hits 2074 2161 +87
- Misses 453 458 +5
- Partials 25 26 +1
Continue to review full report at Codecov.
|
armantekinalp
requested changes
Feb 12, 2022
armantekinalp
left a comment
Contributor
There was a problem hiding this comment.
I think everything looks good. I have some questions, could you please address them @skim0119
armantekinalp
approved these changes
Feb 12, 2022
armantekinalp
left a comment
Contributor
There was a problem hiding this comment.
LGTM, one small documentation comment.
3d89597 to
d837a80
Compare
d837a80 to
c629a78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Note
Related to #54 , the current
constraintcomponent does not pass the indices to the class methods. As a result, it is difficult to implement constraint or boundary conditions at the middle of the rod. I talked to @tp5uiuc, and this is definitely not intended behavior.To fix the issue and improve future functionality, I'm exposing
system(rod),position indices, anddirector indicesto the constraining/BC class. This should make BC implementation more flexible.In addition, I refactored @nmnaughton 's implementation on more general BC:
FixedRodBCandFixedNodeBC(#54). I added an example script on how to use new constraintFixedConstraint. The PR also includes test codes.How to use
FixedConstraintUpdate
ConstraintBaseabstract class is added to provide template for all constraint classes.FreeRodshould not get errors, but a deprecation warning should appear.system,position_indices, anddirector_indicesare added.FreeRodandOneEndFixedRodare refactored toFreeBCandOneEndFixedBC. I made an alias and deprecation note so that people have time to notice the change and convert their code.FixedConstraintwith documentation.FixedConstraintis added and tested.ConstraintBaseclass is added and tested.resolve #55