Skip to content

Minor update: dissipation scaling between translation and rotation#392

Closed
skim0119 wants to merge 3 commits into
GazzolaLab:update-0.3.3from
skim0119:wip/354-dissipation
Closed

Minor update: dissipation scaling between translation and rotation#392
skim0119 wants to merge 3 commits into
GazzolaLab:update-0.3.3from
skim0119:wip/354-dissipation

Conversation

@skim0119
Copy link
Copy Markdown
Collaborator

@skim0119 skim0119 added the discussion Topic that needs to be discussed. label Jun 12, 2024
@skim0119 skim0119 requested review from armantekinalp and sy-cui June 12, 2024 00:39
@skim0119 skim0119 self-assigned this Jun 12, 2024
@sy-cui
Copy link
Copy Markdown
Contributor

sy-cui commented Jun 26, 2024

Couple of points here:

  • Static cases like axial stretching and timoshenko are okay. The analytical results are recovered
  • Catenary case blows up with the current parameter. Might need to adjust the damping constant
  • Snake and flagella cases are broken due to some issue in base_system (e.g. run the snake case to replicate the issue). It does not seem to be related to this PR.
  • The new implementation is okay, but it erases the original behavior and may break user code after the update is released. I thought the plan was to keep the original behavior but add a deprecation warning?

@skim0119
Copy link
Copy Markdown
Collaborator Author

Catenary case blows up with the current parameter. Might need to adjust the damping constant

@Ali-7800 Do you remember how you tuned the damping coefficient for Catenary case before?

  • Snake and flagella cases are broken due to some issue in base_system (e.g. run the snake case to replicate the issue). It does not seem to be related to this PR.

Those cases will be fixed with #367

  • The new implementation is okay, but it erases the original behavior and may break user code after the update is released. I thought the plan was to keep the original behavior but add a deprecation warning?

We can do that if we consider this change as an update. I think we can make a hotfix if we consider this change a bug fix. @armantekinalp opinion?

@skim0119 skim0119 closed this Dec 19, 2024
@skim0119 skim0119 deleted the wip/354-dissipation branch December 19, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion Topic that needs to be discussed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants