Skip to content

Update 0.3.2#345

Merged
armantekinalp merged 262 commits into
masterfrom
update-0.3.2
Mar 26, 2024
Merged

Update 0.3.2#345
armantekinalp merged 262 commits into
masterfrom
update-0.3.2

Conversation

@armantekinalp
Copy link
Copy Markdown
Contributor

@armantekinalp armantekinalp commented Mar 11, 2024

Release Checklist

  • Update publication list
  • Update developer list
  • Final check CONTRIBUTING.
  • Final check README.
  • Bump LICENSE year
  • Bump version (pyproject.toml) followed by poetry lock
  • Dependency version (poetry update)
    • ~~Might break some dependency chain.
  • Check if all remove in v0.3.2 or change to XXX in v0.3.2 are resolved.
  • Check dependabot and security

Test

  • Run the tests
  • Run the formatting
  • CI Check
make test

Build / Installation

  • Check if local installation can be done.
conda create --name temp
conda activate temp
conda install python==<version>
which pip
make poetry-download
make install
make install_examples_dependencies
poetry install -E docs
  • Check if one of the examples run.
python examples/ContinuumSnakeCase/continuum_snake.py

Documentation and Website

  • Check all documentations are updated
  • Update version label on documentation
    • docs/conf.py
    • Python version
  • Update version label on website
    • Python version
- BEYOND THIS, EACH STEP SHOULD BE DONE IN SERIAL (STEP_BY_STEPS). -

Last Edit

  • Rebase the commit history (should be done by only one person) right before the PR.

Update

  1. Merge the branch to master
  2. Release on github. It should automatically upload pypi

Post-release Checklist

  • Update RELEASE.md - It should be in based on milestone description.
  • Commit the changes:
git add RELEASE.md
git commit -m "Changelog for upcoming release <version>"

Final Check

  • Test that it pip installs
  • Check the PyPI listing page to make sure that the README, release notes, and roadmap display properly.
  • Edit the release-page on GitHub. Paste the release notes with a title for the release.
  • Check Codcov ID and make sure they are running.
  • Make mirror branch in private repo.

Rahul-JOON and others added 30 commits May 19, 2023 01:08
Task 2: Units test for specific functions part-1
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
Task 2: Unit test for specific functions part 3
Task 3: Pytest for wrapper classes part 1
Task 3: Pytest for wrapper classes part 2
@armantekinalp armantekinalp added prio:high Priority level: high dependencies Pull requests that update a dependency file python Pull requests that update Python code refactor Refactor existing features labels Mar 11, 2024
@armantekinalp armantekinalp requested a review from sy-cui March 11, 2024 20:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 90.06711% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 94.00%. Comparing base (7095d9e) to head (d3fb41f).

Files Patch % Lines
elastica/_contact_functions.py 84.09% 31 Missing and 11 partials ⚠️
elastica/contact_forces.py 91.00% 1 Missing and 8 partials ⚠️
elastica/contact_utils.py 95.67% 4 Missing and 3 partials ⚠️
elastica/memory_block/memory_block_rod.py 92.72% 2 Missing and 2 partials ⚠️
elastica/modules/base_system.py 42.85% 2 Missing and 2 partials ⚠️
elastica/mesh/mesh_initializer.py 95.16% 3 Missing ⚠️
elastica/memory_block/memory_block_rigid_body.py 91.66% 1 Missing and 1 partial ⚠️
elastica/interaction.py 80.00% 1 Missing ⚠️
elastica/modules/memory_block.py 0.00% 1 Missing ⚠️
elastica/version.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   87.78%   94.00%   +6.22%     
==========================================
  Files          43       51       +8     
  Lines        2938     3170     +232     
  Branches      341      347       +6     
==========================================
+ Hits         2579     2980     +401     
+ Misses        335      140     -195     
- Partials       24       50      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armantekinalp
Copy link
Copy Markdown
Contributor Author

@skim0119 @sy-cui @bhosale2 I think we are ready to merge. Just briefly take a look and then we merge this update on Monday.

Copy link
Copy Markdown
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armantekinalp armantekinalp merged commit b8c8807 into master Mar 26, 2024
@skim0119 skim0119 deleted the update-0.3.2 branch March 26, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request prio:high Priority level: high python Pull requests that update Python code refactor Refactor existing features update Update the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants