Refactor rod-plane contact examples + Continuum Snake With Lifting Wave example#317
Merged
Merged
Conversation
Ali-7800
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #317 +/- ##
=============================================
Coverage 93.46% 93.46%
=============================================
Files 51 51
Lines 3183 3183
Branches 348 348
=============================================
Hits 2975 2975
Misses 158 158
Partials 50 50 ☔ View full report in Codecov by Sentry. |
armantekinalp
requested changes
Nov 17, 2023
Contributor
armantekinalp
left a comment
armantekinalp
left a comment
There was a problem hiding this comment.
Some comments. Can you also add videos for snakes and plots for validation cases for reference.
Collaborator
Author
Examples videos/plots:MuscularSnake2D_xy_muscular_snake.mp4
Axial Friction
rolling friction torque
rolling friction on inclined plane
rolling friction initial velocity
Continuum snake with lifting wavecontinuum_snake_with_lifting_wave.mp4Continuum Snakecontinuum_snake.mp4
armantekinalp
approved these changes
Nov 28, 2023
Contributor
armantekinalp
left a comment
armantekinalp
left a comment
There was a problem hiding this comment.
LGTM just two comments.
Contributor
skim0119
reviewed
Dec 1, 2023
sy-cui
reviewed
Dec 1, 2023
skim0119
reviewed
Dec 2, 2023
skim0119
approved these changes
Dec 5, 2023
Collaborator
skim0119
left a comment
skim0119
left a comment
There was a problem hiding this comment.
Looks good on my end 👍
Contributor
|
@Ali-7800 you can merge whenever you want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixth contact module PR mentioned in Issue
This PR includes: