Skip to content

239 fix restart functionality#249

Merged
bhosale2 merged 2 commits into
GazzolaLab:update-0.3.1from
armantekinalp:239_fix_restart_functionality
May 11, 2023
Merged

239 fix restart functionality#249
bhosale2 merged 2 commits into
GazzolaLab:update-0.3.1from
armantekinalp:239_fix_restart_functionality

Conversation

@armantekinalp

Copy link
Copy Markdown
Contributor

We ran two different simulations to test if restart working, dynamic cantilever and ring rod under gravity. Nodal acceleration in time are compared with restart and without restart.

Dynamic cantilever beam

Dynamic_cantilever_visualization_accelerations

Ring rod under gravity

ring_rod_middle_node_acceleration_testing_restart

@armantekinalp armantekinalp added this to the Version 0.3.1 milestone May 11, 2023
@armantekinalp armantekinalp added bug Something isn't working enhancement New feature or request labels May 11, 2023
@armantekinalp armantekinalp self-assigned this May 11, 2023
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 🎉

Comparison is base (39d3ae9) 87.75% compared to head (2b92732) 87.92%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@               Coverage Diff                @@
##           update-0.3.1     #249      +/-   ##
================================================
+ Coverage         87.75%   87.92%   +0.17%     
================================================
  Files                43       43              
  Lines              3022     3024       +2     
  Branches            348      350       +2     
================================================
+ Hits               2652     2659       +7     
+ Misses              341      338       -3     
+ Partials             29       27       -2     
Impacted Files Coverage Δ
elastica/restart.py 93.75% <100.00%> (+13.75%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bhosale2 bhosale2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bhosale2 bhosale2 linked an issue May 11, 2023 that may be closed by this pull request
@bhosale2 bhosale2 merged commit 3521ce1 into GazzolaLab:update-0.3.1 May 11, 2023
@bhosale2 bhosale2 deleted the 239_fix_restart_functionality branch May 11, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible Bug: Test restart functionality and applying constrains

3 participants