Skip to content

(#164) fix damping force direction#170

Merged
armantekinalp merged 6 commits into
GazzolaLab:update-0.3.0from
bhosale2:164_fix_damping_force_direction
Aug 10, 2022
Merged

(#164) fix damping force direction#170
armantekinalp merged 6 commits into
GazzolaLab:update-0.3.0from
bhosale2:164_fix_damping_force_direction

Conversation

@bhosale2
Copy link
Copy Markdown
Collaborator

@bhosale2 bhosale2 commented Aug 7, 2022

Fixes #164.

@bhosale2 bhosale2 added invalid This doesn't seem right prio:high Priority level: high labels Aug 7, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Aug 7, 2022
@bhosale2 bhosale2 self-assigned this Aug 7, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 7, 2022

Codecov Report

Merging #170 (43a650a) into update-0.3.0 (4974ba1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 43a650a differs from pull request most recent head c6656af. Consider uploading reports for the commit c6656af to get more accurate results

@@               Coverage Diff                @@
##           update-0.3.0     #170      +/-   ##
================================================
- Coverage         87.62%   87.60%   -0.03%     
================================================
  Files                43       43              
  Lines              2820     2815       -5     
  Branches            368      367       -1     
================================================
- Hits               2471     2466       -5     
  Misses              328      328              
  Partials             21       21              
Impacted Files Coverage Δ
elastica/joint.py 25.16% <100.00%> (-1.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Copy Markdown
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets restore the collision/AABBCollection.py for now

@bhosale2
Copy link
Copy Markdown
Collaborator Author

bhosale2 commented Aug 7, 2022

@skim0119 reverted back folder in 43a650a

@bhosale2 bhosale2 linked an issue Aug 7, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @bhosale2 for fixing this.

@armantekinalp armantekinalp merged commit f9b891f into GazzolaLab:update-0.3.0 Aug 10, 2022
@bhosale2 bhosale2 deleted the 164_fix_damping_force_direction branch August 18, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right prio:high Priority level: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cross-check and modify if needed joint damping force direction

4 participants