fix(retrocompatibility): make test suite pass with sequelize@4.x#761
Merged
Conversation
romain-gilliotte
changed the title
romain-gilliotte
force-pushed
the
fix/sequelize-4-support
branch
from
6872bc0 to
5ff74f8
Compare
added 2 commits
June 24, 2021 16:39
…t the same than locally (node version?)
larcin
approved these changes
Jun 28, 2021
Comment on lines
+51
to
+58
| if (include.sequelize) { | ||
| return { | ||
| model: include, | ||
| as: Object | ||
| .keys(model.associations) | ||
| .find((association) => model.associations[association].target.name === include.name), | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
[MISC] I don't get the usage solved here 🤔
forest-bot
added a commit
that referenced
this pull request
Jun 28, 2021
## [7.11.4](v7.11.3...v7.11.4) (2021-06-28) ### Bug Fixes * **retrocompatibility:** make test suite pass with sequelize@4.x ([#761](#761)) ([a04be5c](a04be5c))
Member
|
🎉 This PR is included in version 7.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Jul 6, 2021
# [8.0.0-beta.9](v8.0.0-beta.8...v8.0.0-beta.9) (2021-07-06) ### Bug Fixes * fix types ([580ef41](580ef41)) * support inverseOf property ([#760](#760)) ([6fab976](6fab976)) * **authentication:** error during authentication when the environment is secret passed as a liana option and not an environment variable ([#758](#758)) ([39ab674](39ab674)) * **intercom:** fix date conversion from unix timestamp to js date of intercom attributes ([#754](#754)) ([11a1549](11a1549)) * **retrocompatibility:** make test suite pass with sequelize@4.x ([#761](#761)) ([a04be5c](a04be5c)) * fix mssql ordering collection by pk ([#734](#734)) ([7bbd19d](7bbd19d)) * prevent IP check from failing for the proxies including the port in the headers ([#751](#751)) ([92852f7](92852f7)) ### Features * add typescript declaration file ([#743](#743)) ([a536f1c](a536f1c)) * include role in the user data inside the request ([#746](#746)) ([425bba5](425bba5))
Member
|
🎉 This PR is included in version 8.0.0-beta.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix retrocompatibility with sequelize 4.
The issue in the ticket is due to the fact than in Sequelize 4, it is illegal to join the same relation twice.
This happens in smart field cutom search, when customers inject "include" into the query options