chore(security): patch 4 Dependabot alerts#1656
Open
PMerlet wants to merge 1 commit into
Open
Conversation
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
4 fixed, 1 ignored, 6 deferred, 1 resolution added, 0 resolutions removed. | label: 🔒 security applied
Fixed
axios^1.15.0→^1.16.0inpackages/forest-cloud/package.json; added root resolutionaxios: ">=1.16.0"to cover the still-vulnerablelerna > nx > axios@1.15.2transitive copy.qs">=6.14.1"→">=6.15.2"(the previous pin was inside the vulnerable range).uuid"^10.0.0"→"^11.1.1". Repo only usesv1,v4, andvalidate— none of the buffer-bounds-affectedv3/v5/v6paths.tmp: ">=0.2.6". Lifts both transitive copies (lerna's tree andinquirer > external-editor'stmp@0.0.33); thetmp.fileSync({ prefix, ... })API used downstream is preserved across 0.0.x → 0.2.x.The axios bump also lifts the still-deferred axios alerts (#372, #373, #374, #375, #376) to a patched version as a side effect — they share the same patched version (axios 1.16.0). They remain listed in Deferred because they were opened < 7 days ago; Dependabot will close them automatically once this merges.
Ignored
_example > tedious > @azure/identity > … > http-proxy-agent—_example/is not shipped to production; (2)_example > sqlite3 > node-gyp > make-fetch-happen > http-proxy-agent— build-time only when downloading prebuilt binaries; (3)@forestadmin/agent (devDependency) > sqlite3 > node-gyp > …— sqlite3 is adevDependencyinpackages/agent, used only by tests. No source code in the repo imports@tootallnate/oncedirectly. A>=2.0.1resolution is not viable here because the deep chains pin major1.x(incompatible API across the 1.x → 2.x boundary).Deferred (opened < 7 days ago)
Resolutions added
tmp >=0.2.6lerna > nx > tmp@0.2.1,lerna > @nx/devkit > tmp@0.2.1,inquirer > external-editor > tmp@0.0.33lernamajor would not lift its pinned transitivetmpminor;external-editor@3.1.0still pinstmp ^0.0.33upstream, so a parent bump cannot reach>=0.2.6without upstream changes outside our control. Thetmp.fileSync({ prefix, postfix, ... })API used downstream is stable across the 0.0 → 0.2 jump.package.json(root)qs >=6.15.2body-parser,express,superagent,co-body, …) across multiple workspaces">=6.14.1"for the same reason; the new advisory bumped the vulnerable range to<=6.15.1. Updating the existing pin is strictly the same form as before.package.json(root)uuid ^11.1.1sequelize,@langchain/langgraph,excel4node,forest-cli, …)^10.0.0; the advisory affects all< 11.1.1. Updating the existing pin is strictly the same form as before.package.json(root)axios >=1.16.0lerna > nx > axios@1.15.2lernato its current latest still resolves to the samenx > axios@1.15.2. A direct bump inpackages/forest-cloud/package.jsonlifts the user-facing copy but does not reach thelerna/nxsubtree.package.json(root)Risks
NO_PROXY/IPv6 handling — exactly the surface area we're trying to patch. No public API removals in 1.16/1.17 vs 1.15;forest-cli's axios usage is plain GETs/POSTs with bearer auth, unaffected.qs.stringifycrash onnull/undefinedin comma-format arrays. No API changes.parse()to requireUint8Array. Our usage isv1,v4, andvalidateonly — unaffected.external-editor): patch path for the lerna-side copy; theexternal-editorjump skips the0.1.xline.fileSync({ prefix, postfix })+removeCallback()signature is preserved across all versions in scope.Manual testing
Covered by CI.
forest-cli(the only direct axios consumer in scope) and the workflow-executor / mcp-server packages exercise the upgraded paths via Jest suites.Validation
✅ CI green