Skip to content

fix(workflow): set durations to seconds#1646

Merged
EnkiP merged 3 commits into
mainfrom
fix/seconds-duration
Jun 11, 2026
Merged

fix(workflow): set durations to seconds#1646
EnkiP merged 3 commits into
mainfrom
fix/seconds-duration

Conversation

@EnkiP

@EnkiP EnkiP commented Jun 10, 2026

Copy link
Copy Markdown
Member

Definition of Done

fixes PRD-483

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Note

Convert workflow-executor time configuration from milliseconds to seconds

  • All time-related fields in ExecutorOptions, RunnerConfig, ExecutionContext, and StepContextConfig are renamed from *Ms to *S (e.g. pollingIntervalMspollingIntervalS).
  • Default constants in defaults.ts are now expressed in seconds; call sites multiply by 1000 when passing to setTimeout or AbortSignal.timeout.
  • CLI env vars (POLLING_INTERVAL_MS, STOP_TIMEOUT_MS, etc.) are renamed to *_S equivalents; the old *_MS vars are no longer read.
  • Error messages and structured log fields (timeoutMs) are updated to report seconds.
  • Behavioral Change: any existing deployments using *_MS env vars must switch to *_S vars with second-based values or timeouts will be unset/default.

Changes since #1646 opened

  • Updated the default value of the POLLING_INTERVAL_S environment variable from 5 to 30 seconds in the workflow-executor package documentation [d3e3b58]
📊 Macroscope summarized 844130e. 14 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@qltysh

qltysh Bot commented Jun 10, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/runner.ts100.0%
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/build-workflow-executor.ts100.0%
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/executors/base-step-executor.ts100.0%
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/schema-cache.ts100.0%
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/defaults.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@linear-code

linear-code Bot commented Jun 10, 2026

Copy link
Copy Markdown

PRD-483

@EnkiP EnkiP force-pushed the fix/seconds-duration branch from 77ccdde to 844130e Compare June 11, 2026 09:29
Comment thread packages/workflow-executor/README.md Outdated
@EnkiP EnkiP merged commit 7766363 into main Jun 11, 2026
30 checks passed
@EnkiP EnkiP deleted the fix/seconds-duration branch June 11, 2026 11:19
forest-bot added a commit that referenced this pull request Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants