Conversation
rodrigorsa
force-pushed
the
housekeeping/removing-forced-unwrapping
branch
from
00f7721 to
0db0713
Compare
hebertialmeida
left a comment
hebertialmeida
left a comment
There was a problem hiding this comment.
I have just added a question, let me know what do you think.
|
|
||
| var activeClass: String { | ||
| guard let className = metadata.findMetaByProperty("media:active-class") else { | ||
| guard let className = metadata.find(byProperty: "media:active-class")?.value else { |
There was a problem hiding this comment.
I don't get why use .value here and not wrap it in the function as it was before.
There was a problem hiding this comment.
Since metadata is an object it does not make sense a method named findMetaByProperty() or find(byProperty:) returns a String. In the previous implementation there were two methods named findMetaByName and findMetaByProperty and they were returning different "contents" that is weird. I guess now these method are more consistent and the developer can choose witch Meta's property is better to use
|
|
||
| var playbackActiveClass: String { | ||
| guard let className = metadata.findMetaByProperty("media:playback-active-class") else { | ||
| guard let className = metadata.find(byProperty: "media:playback-active-class")?.value else { |
There was a problem hiding this comment.
Same here and in the others that use .value
There was a problem hiding this comment.
The same as above
|
|
||
| var activeClass: String { | ||
| guard let className = metadata.findMetaByProperty("media:active-class") else { | ||
| guard let className = metadata.find(byProperty: "media:active-class")?.value else { |
2 participants
No description provided.