race cond: Core.parseKeys returns result of another key

[tomholub]

even though I have a matching private key

also can view encrypted emails without issue

[tomholub]

This looks serious - I'm pulling private keys from my own storage (which I know are correct based on Settings -> Keys) but somehow the recipient's keys user id email is getting mixed into it (my own key gets replaced with theirs, and then email doesn't match)

"⚙️[KeyService][KeyService] findKeyByUserEmail: found 3 candidate prvs in storage, searching by:tom@flowcrypt.com"
"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.091 ms GET https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/hu/y1n3m33zk1ps45rgzz6c69tbbjzqbcpz?l=sosnovsky, headers: [:]"
"ℹ️[WKDURLsService] Loaded WKD url https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/hu/y1n3m33zk1ps45rgzz6c69tbbjzqbcpz?l=sosnovsky and will try to extract Public Keys"
"⚙️[KeyService][KeyService] findKeyByUserEmail: candidate key 955F0486D70A3FB563302887BB2C18FB6B13EE79 has emails Optional([\"sosnovsky@flowcrypt.com\"])"
"⚙️[KeyService][KeyService] findKeyByUserEmail: candidate key 8A030BAB42CAD97FF26AA25E283DDD9A77AD6AF2 has emails Optional([\"security@flowcrypt.com\"])"
"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.304 ms GET https://flowcrypt.com/attester/pub/sosnovsky@flowcrypt.com, headers: [:]"
"⚙️[KeyService][KeyService] findKeyByUserEmail: candidate key 955F0486D70A3FB563302887BB2C18FB6B13EE79 has emails Optional([\"sosnovsky@flowcrypt.com\"])"
"⚙️[KeyService][KeyService] findKeyByUserEmail: could not match any key"
"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.152 ms GET https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/policy, headers: [:]"
"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.104 ms GET https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/hu/y1n3m33zk1ps45rgzz6c69tbbjzqbcpz?l=sosnovsky, headers: [:]"
"ℹ️[WKDURLsService] Loaded WKD url https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/hu/y1n3m33zk1ps45rgzz6c69tbbjzqbcpz?l=sosnovsky and will try to extract Public Keys"

The WKD lookup and the private key fetch, and parsing of both, happens at the same time concurrently. So I wonder if the parser gives wrong result to wrong callback.

[tomholub]

I'll do some more debugging, and I may write a concurrent test for the key parser to see if I can catch the problem.

[tomholub]

Confirmed:

"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.402 ms GET https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/policy, headers: [:]"
"⚙️[KeyService][KeyService] findKeyByUserEmail: found 3 candidate prvs in storage, searching by:tom@flowcrypt.com"
"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.083 ms GET https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/hu/y1n3m33zk1ps45rgzz6c69tbbjzqbcpz?l=sosnovsky, headers: [:]"
"ℹ️[WKDURLsService] Loaded WKD url https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/hu/y1n3m33zk1ps45rgzz6c69tbbjzqbcpz?l=sosnovsky and will try to extract Public Keys"
"⚙️[KeyService][KeyService] findKeyByUserEmail: PrvKeyInfo from storage has primary fingerprint 1D9AA995F878AB39316A157C84AE4C8A1923A36A vs parsed key 955F0486D70A3FB563302887BB2C18FB6B13EE79 and has emails Optional([\"sosnovsky@flowcrypt.com\"])"
"⚙️[KeyService][KeyService] findKeyByUserEmail: PrvKeyInfo from storage has primary fingerprint 8A030BAB42CAD97FF26AA25E283DDD9A77AD6AF2 vs parsed key 8A030BAB42CAD97FF26AA25E283DDD9A77AD6AF2 and has emails Optional([\"security@flowcrypt.com\"])"
"⚙️[KeyService][KeyService] findKeyByUserEmail: PrvKeyInfo from storage has primary fingerprint 8B8A05A2216EE6E4C5EE3D540D5688EBF3102BE7 vs parsed key 8B8A05A2216EE6E4C5EE3D540D5688EBF3102BE7 and has emails Optional([\"tom@bitoasis.net\"])"
"⚙️[KeyService][KeyService] findKeyByUserEmail: could not match any key"
"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.418 ms GET https://flowcrypt.com/attester/pub/sosnovsky@flowcrypt.com, headers: [:]"
"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.060 ms GET https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/policy, headers: [:]"
"ℹ️[URLSession] URLSession.asyncCall status:200 ms:0.177 ms GET https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/hu/y1n3m33zk1ps45rgzz6c69tbbjzqbcpz?l=sosnovsky, headers: [:]"
"ℹ️[WKDURLsService] Loaded WKD url https://openpgpkey.flowcrypt.com/.well-known/openpgpkey/flowcrypt.com/hu/y1n3m33zk1ps45rgzz6c69tbbjzqbcpz?l=sosnovsky and will try to extract Public Keys"

This line: "⚙️[KeyService][KeyService] findKeyByUserEmail: PrvKeyInfo from storage has primary fingerprint 1D9AA995F878AB39316A157C84AE4C8A1923A36A vs parsed key 955F0486D70A3FB563302887BB2C18FB6B13EE79 and has emails Optional([\"sosnovsky@flowcrypt.com\"])" - the key that comes back from parser is a different key than the one we were parsing.

[ivan-ushakov]

@tomholub
I can take a look

[tomholub]

For now I'm looking into it. It's code I wrote