Skip to content

Remove pytz and replace usage with core python modules #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gagantrivedi merged 1 commit into from
Apr 5, 2024
Merged

Remove pytz and replace usage with core python modules #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ repos:
- id: mypy
args: [--strict]
additional_dependencies:
[pydantic, pytest, pytest_mock, types-requests, flagsmith-flag-engine, responses, types-pytz, sseclient-py]
[pydantic, pytest, pytest_mock, types-requests, flagsmith-flag-engine, responses, sseclient-py]
- repo: https://github.com/PyCQA/isort
rev: 5.12.0
hooks:
Expand Down
7 changes: 3 additions & 4 deletions flagsmith/flagsmith.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import json
import logging
import typing
from datetime import datetime
from datetime import datetime, timezone

import pytz
import requests
from flag_engine import engine
from flag_engine.environments.models import EnvironmentModel
Expand Down Expand Up @@ -212,15 +211,15 @@ def handle_stream_event(self, event: StreamEvent) -> None:
) from e

if stream_updated_at.tzinfo is None:
stream_updated_at = pytz.utc.localize(stream_updated_at)
stream_updated_at = stream_updated_at.astimezone(timezone.utc)

if not self._environment:
raise ValueError(
"Unable to access environment. Environment should not be null"
)
environment_updated_at = self._environment.updated_at
if environment_updated_at.tzinfo is None:
environment_updated_at = pytz.utc.localize(environment_updated_at)
environment_updated_at = environment_updated_at.astimezone(timezone.utc)

if stream_updated_at > environment_updated_at:
self.update_environment()
Expand Down
24 changes: 1 addition & 23 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ requests = "^2.27.1"
requests-futures = "^1.0.0"
flagsmith-flag-engine = "^5.1.0"
sseclient-py = "^1.8.0"
pytz = "^2023.4"

[tool.poetry.group.dev]
optional = true
Expand All @@ -31,7 +30,6 @@ isort = "^5.12.0"
mypy = "^1.7.1"
types-requests = "^2.31.0.10"
pytest-cov = "^4.1.0"
types-pytz = "^2024.1.0.20240203"

[tool.mypy]
plugins = ["pydantic.mypy"]
Expand Down