[WIP] Add "theme_experiment" addon support#144
Closed
trickypr wants to merge 7 commits intoFirefoxCSS-Store:mainfrom
Closed
[WIP] Add "theme_experiment" addon support#144trickypr wants to merge 7 commits intoFirefoxCSS-Store:mainfrom
trickypr wants to merge 7 commits intoFirefoxCSS-Store:mainfrom
Conversation
Collaborator
Collaborator
|
I think this actually could be pretty easy – we can tag all themes accordingly and just generate the static files according to wheter the tag is present or not. This would again remove any computational stuff client side. |
Author
|
I probably won't continue working in this. If you want to steal any of my code, feel free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this
This is an implementation with the goal of closing #143. You can find more information by reading it.
tl;dr: There is a way of distributing themes as extensions to Firefox Nightly and Firefox forks.
Specific details
This adds the ability for a user to select the browser they are using and be provided with install instructions for using "theme_experiment" addons within their browser. There is currently no way to have themes that only support "theme_experiment" but themes without "theme_experiment" are not impacted in any way.
Checklist
themes.jsonLive demo: https://trickypr.github.io/FirefoxCSS-Store.github.io/