Skip to content

Creation of backup and restore statistics can be switched off - #1182

Merged
cincuranet merged 4 commits into
FirebirdSQL:masterfrom
DevM900:master
Jul 17, 2024
Merged

Creation of backup and restore statistics can be switched off #1182
cincuranet merged 4 commits into
FirebirdSQL:masterfrom
DevM900:master

Conversation

@DevM900

@DevM900 DevM900 commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

By setting the new property FbBackup.IncludeStatistics to false fixes #1180.
To ensure backward compatibility, the default value of the FbBackup.IncludeStatistics property is true.

@cincuranet

Copy link
Copy Markdown
Member

I'm wondering whether instead of introducing new property making Statistics nullable would do the same job...

@DevM900

DevM900 commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

My initial intention was not to change any existing property.
But I think making the Statistics property nullable is also fine.
When I think about the users of the class, however, I can't judge which is the better solution.

@DevM900

DevM900 commented Jul 12, 2024

Copy link
Copy Markdown
Contributor Author

If you prefer nullable, I'd change that.

@cincuranet

Copy link
Copy Markdown
Member

Yeah, I would go with nullable. Unless it blows in some unexpected way, it seems better to me.

To perform a backup or restore without determining the statistics values, the `Statistics` property can be set to `null`.
The property `IncludeStatistics` is therefore no longer required.
@DevM900

DevM900 commented Jul 12, 2024

Copy link
Copy Markdown
Contributor Author

Done.

Comment thread src/FirebirdSql.Data.FirebirdClient/Services/FbBackup.cs Outdated
Comment thread src/FirebirdSql.Data.FirebirdClient/Services/FbRestore.cs Outdated
DevM900 added 2 commits July 15, 2024 11:21
To perform a restore without determining the statistics values, the `Statistics` property can be set to `null`.
The property `IncludeStatistics` is therefore no longer required.
@DevM900
DevM900 requested a review from cincuranet July 17, 2024 05:33

@cincuranet cincuranet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cincuranet
cincuranet merged commit 4d174f3 into FirebirdSQL:master Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot create backup on firebird server 2.0

2 participants