docs(ci): enable localStorage in Node.js 25 to avoid build error#329
Merged
docs(ci): enable localStorage in Node.js 25 to avoid build error#329
Conversation
Node.js 25 became "current" and our CI is now testing it. We now have a failure because "localStorage" is now a thing in Node.js but it's not properly enabled without the arg. So @typescript/vfs, which in the browser detects a "localStorage" and tries to use it (but previously in Node.js wouldn't find it so wouldn't try) finds an implementation that's incomplete. This change activates it, so we don't get the error. But we don't really need it, so this can be wound back when we have a fix in vfs or somewhere else in the stack. Ref: nodejs/node#57666 Ref: microsoft/TypeScript-Website#3449 Ref: microsoft/TypeScript-Website#3450
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 9c9eeb5 | Commit Preview URL Branch Preview URL |
Oct 20 2025, 02:03 AM |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
wjmelements
reviewed
Oct 21, 2025
| "scripts": { | ||
| "dev": "astro dev", | ||
| "build": "astro build", | ||
| "build": "NODE_OPTIONS=\"--localstorage-file=.astro-localstorage.json\" astro build", |
Contributor
There was a problem hiding this comment.
Seems the default is no local storage
Collaborator
Author
There was a problem hiding this comment.
yeah .. we don't actually want local storage, none of this is useful, it's all just a fault in @typescript/vfs that will eventually be ironed out
wjmelements
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 25 became "current" and our CI is now testing it. We now have a failure because "localStorage" is now a thing in Node.js but it's not properly enabled without the arg. So @typescript/vfs, which in the browser detects a "localStorage" and tries to use it (but previously in Node.js wouldn't find it so wouldn't try) finds an implementation that's incomplete.
This change activates it, so we don't get the error. But we don't really need it, so this can be wound back when we have a fix in vfs or somewhere else in the stack.
Ref: nodejs/node#57666
Ref: microsoft/TypeScript-Website#3449
Ref: microsoft/TypeScript-Website#3450