Add getTypeIndex and getPacketByIndex functions to Decoder#8
Merged
Conversation
Bump fork to V3
TrentHouliston
requested changes
Feb 15, 2024
Member
TrentHouliston
left a comment
TrentHouliston
left a comment
There was a problem hiding this comment.
Partial review, will look more closely later
JosephusPaye
requested changes
Feb 19, 2024
awann-4ai
changed the title
index property and getPacketByIndex to DecodergetTypeIndex and getPacketByIndex functions to Decoder
TrentHouliston
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functions to allow the index timestamps to be requested from the Decoder and request packets using an index.