chore(rebrand): rename Constants.cs internals (NukeFileName, NukeDirectoryName, etc.)#60
Merged
Merged
Conversation
…ctoryName, etc.) → Fallout* Mechanical rename of the internal-only legacy constants in Fallout.Build.Shared.Constants and their call sites: NukeFileName → FalloutFileName NukeDirectoryName → FalloutDirectoryName NukeCommonPackageId → FalloutCommonPackageId GetNukeDirectory → GetFalloutDirectory GlobalNukeDirectory → GlobalFalloutDirectory All five symbols are `internal` so this has no consumer-visible impact — purely cleanup of leftover legacy naming. Refs #57. ## Carve-outs preserved (deliberate) - `LegacyNukeDirectoryName` — back-compat constant whose VALUE is the literal `.nuke`, so renaming the symbol would be misleading. - `UpstreamNukeRepository` / `UpstreamNukeRepositoryGit` — legacy recognition pointers to nuke-build/nuke. - `NukeTelemetryVersion` — MSBuild property in user-facing templates; deferred to the MSBuild-prop deprecation PR. ## Verification - dotnet build fallout.slnx -c Debug: 0 errors, 15 pre-existing warnings - dotnet test fallout.slnx: 391 passed, 7 skipped, 0 failed Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ChrisonSimtian
added a commit
that referenced
this pull request
May 22, 2026
CLAUDE.md no longer claimed the Nuke.* → Fallout.* structural rename was pending — that landed in #54, #60, #65, #66 ages ago. Updates the rebrand-status paragraph, the src/tests layout table, the production project groupings (now including Fallout.Migrate and the vendored Fallout.VisualStudio.SolutionPersistence), the tool-wrapper paths, and fixes the CI-revival roadmap link from #7 (which is the CodeQL ticket) to #8 (the actual CI-revival tracker). README.md said releases publish to GitHub Packages — nuget.org has been the primary feed since #58. Build-status table also had three URLs hardcoded to ChrisonSimtian/nuke (the pre-rename slug). Also notes the new docs-only paths-ignore on the release workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical rename of five internal-only constants in
Fallout.Build.Shared.Constantsplus their call sites:NukeFileNameFalloutFileNameNukeDirectoryNameFalloutDirectoryNameNukeCommonPackageIdFalloutCommonPackageIdGetNukeDirectory(...)GetFalloutDirectory(...)GlobalNukeDirectoryGlobalFalloutDirectoryAll five symbols are
internal— zero consumer-visible impact. Just leftover legacy naming.14 files changed, 39 lines on each side. Refs #57.
Carve-outs preserved (deliberate)
LegacyNukeDirectoryName— back-compat constant whose value is the literal.nuke; renaming the symbol would be misleading.UpstreamNukeRepository/UpstreamNukeRepositoryGit— pointers tonuke-build/nukefor legacy URL recognition.NukeTelemetryVersion— MSBuild property in user-facing templates; deferred to the MSBuild-prop deprecation PR with the rest of that family.Verification
dotnet build fallout.slnx -c Debug: 0 errors, 15 pre-existing warningsdotnet test fallout.slnx: 391 passed, 7 skipped, 0 failedTest plan
ubuntu-latestCI green🤖 Generated with Claude Code