Add missing ArtifactsPath property to dotnet restore#506
Conversation
|
I miss the rationale. Why do we need this? |
|
Idk honestly 🤣 Maybe honor contributions by merging them in (and promote the successor of NUKE) |
Wait, you don't know why this PR is needed? |
|
Hmm.. I "know" that this PR is for merging changes from other contributers, to promote this NUKE successor. But I don't know why this someone needs.. But since it was a PR in NUKE I suppose "someone" needs it. You know what I mean? |
I like the first part, but merging something we don't understand doesn't make sense to me. |
|
Well... it's up to you. I thought I'd be a quick win. |
|
Needs to be rerun after #512 is merged as invoking |
dbede01 to
675d1df
Compare
675d1df to
1271d85
Compare
Adds the missing
ArtifactsPath(--artifacts-path) property to thedotnet restoretool wrapper definition (DotNet.json), ported from upstream NUKE PR #1518.From here: nuke-build/nuke#1518
Thanks @SigtryggurO
Added value: since
.cswrappers are generated from these JSON specs, this lets consumers callDotNetTasks.DotNetRestore(s => s.SetArtifactsPath(...))in a strongly-typed way instead of falling back to raw arguments — closing a gap versus otherdotnetsubcommands that already expose this option (available since .NET 8 SDK).