Skip to content

Add missing ArtifactsPath property to dotnet restore#506

Merged
dennisdoomen merged 1 commit into
Fallout-build:mainfrom
IT-VBFK:fix/tools/missing-dotnet-param
Jul 19, 2026
Merged

Add missing ArtifactsPath property to dotnet restore#506
dennisdoomen merged 1 commit into
Fallout-build:mainfrom
IT-VBFK:fix/tools/missing-dotnet-param

Conversation

@IT-VBFK

@IT-VBFK IT-VBFK commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Adds the missing ArtifactsPath (--artifacts-path) property to the dotnet restore tool wrapper definition (DotNet.json), ported from upstream NUKE PR #1518.

From here: nuke-build/nuke#1518

Thanks @SigtryggurO

Added value: since .cs wrappers are generated from these JSON specs, this lets consumers call DotNetTasks.DotNetRestore(s => s.SetArtifactsPath(...)) in a strongly-typed way instead of falling back to raw arguments — closing a gap versus other dotnet subcommands that already expose this option (available since .NET 8 SDK).

@IT-VBFK
IT-VBFK requested a review from a team as a code owner July 17, 2026 17:41
@ITaluone ITaluone added enhancement New feature or request target/vCurrent Targets the current version labels Jul 17, 2026
@dennisdoomen

Copy link
Copy Markdown
Collaborator

I miss the rationale. Why do we need this?

@IT-VBFK

IT-VBFK commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Idk honestly 🤣

Maybe honor contributions by merging them in (and promote the successor of NUKE)

@dennisdoomen

Copy link
Copy Markdown
Collaborator

Idk honestly 🤣

Wait, you don't know why this PR is needed?

@IT-VBFK

IT-VBFK commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Hmm.. I "know" that this PR is for merging changes from other contributers, to promote this NUKE successor.

But I don't know why this someone needs.. But since it was a PR in NUKE I suppose "someone" needs it.

You know what I mean?

@dennisdoomen

Copy link
Copy Markdown
Collaborator

Hmm.. I "know" that this PR is for merging changes from other contributers, to promote this NUKE successor.

But I don't know why this someone needs.. But since it was a PR in NUKE I suppose "someone" needs it.

I like the first part, but merging something we don't understand doesn't make sense to me.

@IT-VBFK

IT-VBFK commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Well... it's up to you.

I thought I'd be a quick win.

@dennisdoomen
dennisdoomen marked this pull request as draft July 19, 2026 07:26
@dennisdoomen

Copy link
Copy Markdown
Collaborator

Needs to be rerun after #512 is merged as invoking GenerateTools would trigger a lot of file changes.

@IT-VBFK
IT-VBFK force-pushed the fix/tools/missing-dotnet-param branch from dbede01 to 675d1df Compare July 19, 2026 12:31
@IT-VBFK
IT-VBFK force-pushed the fix/tools/missing-dotnet-param branch from 675d1df to 1271d85 Compare July 19, 2026 15:42
@dennisdoomen
dennisdoomen marked this pull request as ready for review July 19, 2026 16:20
@dennisdoomen
dennisdoomen merged commit f833149 into Fallout-build:main Jul 19, 2026
1 check passed
@IT-VBFK
IT-VBFK deleted the fix/tools/missing-dotnet-param branch July 19, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request target/vCurrent Targets the current version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants