Add tool wrapper definition for Stryker#503
Conversation
01a4ea9 to
b47b125
Compare
dennisdoomen
left a comment
There was a problem hiding this comment.
⛏🤖 Nitpick: BreakAt is typed uint, but ThresholdHigh/ThresholdLow are typed short, even though all three represent the same 0-100 mutation-score concept and map to the same int? type upstream in Stryker (ThresholdBreakInput, ThresholdHighInput, ThresholdLowInput). Suggest using one consistent numeric type across all three.
❓🤖 Question: the wrapper omits several newer Stryker CLI options that exist in current stryker-net master (CommandLineConfigReader.cs): with-baseline, test-runner, diag, azure-fileshare-sas, s3-bucket-name, s3-endpoint, s3-region. Was this a deliberate scope match with the upstream NUKE PR (nuke-build/nuke#1259), or should these be added now?
|
Thanks for review I "just" took the definitions form the original PR Will add them (or let them add 🤖) |
0e9348f to
8a5fafa
Compare
8a5fafa to
eabcf8d
Compare
Used
Added them now since there were easy :) |
eabcf8d to
22c3072
Compare
ChrisonSimtian
left a comment
There was a problem hiding this comment.
lgtm but lets slow down a bit on adding new tools to the mix :-)
I'd longterm like to break those out into their own little spaces so that people can expand Fallout as they need, without making the core too heavy ;-)
22c3072 to
93f05c2
Compare
From here: nuke-build/nuke#1259
Thanks @candoumbe