Add draft-first PR creation, test naming, and Specs suffix conventions#438
Merged
dennisdoomen merged 1 commit intoJun 29, 2026
Merged
Conversation
dennisdoomen
changed the title
dennisdoomen
changed the title
dennisdoomen
added a commit
to dennisdoomen/Fallout
that referenced
this pull request
Jun 28, 2026
- Add draft-by-default rule to issue-and-pr-style.md (part of PR creation best practices) - Add AV1600 test naming convention to conventions.md (code style) - Revert AGENTS.md to remove overly broad rules; keep canonical brief Closes Fallout-build#438
dennisdoomen
added a commit
to dennisdoomen/Fallout
that referenced
this pull request
Jun 28, 2026
- Create PRs as draft by default (issue-and-pr-style.md) - Test naming follows AV1600 behavior-focused style (conventions.md) - Test files/classes use Specs suffix (conventions.md) - Revert AGENTS.md to remove overly broad rules; keep canonical brief Closes Fallout-build#438
dennisdoomen
force-pushed
the
docs-skill-agents-guidance
branch
from
June 28, 2026 12:07
f893ab9 to
87b29b2
Compare
dennisdoomen
added a commit
to dennisdoomen/Fallout
that referenced
this pull request
Jun 28, 2026
- Create PRs as draft by default (issue-and-pr-style.md) - Test naming follows AV1600 behavior-focused style (conventions.md) - Test files/classes use Specs suffix (conventions.md) - Revert AGENTS.md to remove overly broad rules; keep canonical brief Closes Fallout-build#438
dennisdoomen
force-pushed
the
docs-skill-agents-guidance
branch
from
June 28, 2026 12:08
87b29b2 to
dc1fd56
Compare
dennisdoomen
changed the title
dennisdoomen
marked this pull request as ready for review
June 28, 2026 12:11
ChrisonSimtian
approved these changes
Jun 28, 2026
ChrisonSimtian
left a comment
ChrisonSimtian
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, I like the draft addition for PRs. really should raise PRs as drafts and then get HITL in first before marking it as reviewable (hence the label that we can now get rid of :-) )
ChrisonSimtian
added
the
Can Merge
- Create PRs as draft by default (issue-and-pr-style.md) - Test naming follows AV1600 behavior-focused style (conventions.md) - Test files/classes use Specs suffix (conventions.md) - Revert AGENTS.md to remove overly broad rules; keep canonical brief Closes Fallout-build#438
dennisdoomen
force-pushed
the
docs-skill-agents-guidance
branch
from
June 29, 2026 04:38
dc1fd56 to
fe15af9
Compare
dennisdoomen
enabled auto-merge (rebase)
June 29, 2026 04:38
dennisdoomen
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three focused documentation rules to guide agent and human contributors on testing and PR creation practices.
What changed
docs/agents/issue-and-pr-style.md: Added draft-by-default rule (PRs created as draft unless explicitly requested otherwise)docs/agents/conventions.md: Added AV1600 test naming convention (behavior-focused, present-tense test names) and Specs suffix convention (test projects/files/classes useSpecssuffix instead ofTest/Tests)Why
These rules belong in domain-specific docs where they apply. Draft creation is part of PR best practices (issue-and-pr-style), and test naming conventions are code style (conventions). Using
Specsclarifies behavior-specification semantics in testing.