Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
# changelogs, etc.) have no code owner and are gated only by the required CI
# status check.

/src/** @ChrisonSimtian
/tests/** @ChrisonSimtian
/src/** @Fallout-build/maintainers
/tests/** @Fallout-build/maintainers
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ jobs:
for pkg in "${packages[@]}"; do
echo "Pushing $pkg to GitHub Packages..."
dotnet nuget push "$pkg" \
--source "https://nuget.pkg.github.com/ChrisonSimtian/index.json" \
--source "https://nuget.pkg.github.com/Fallout-build/index.json" \
--api-key "${{ secrets.GITHUB_TOKEN }}" \
--skip-duplicate
done
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ The NUKE → Fallout hard fork. Originally NUKE by [@matkoch](https://github.com
### Backwards-compat: Nuke.* transition shims
- **`Nuke.Common` MVP shim package** (#70): thin wrapper assembly in the `Nuke.*` namespace whose types inherit from the corresponding `Fallout.*` types — lets pre-rename consumers compile against the new packages without source changes. Lives at `src/Shims/Nuke.Common/`.
- **`TransitionShimGenerator` source generator** (#69): emits shim type wrappers per-target, covering the Nuke.Common "Easy tier" surface (plain types, interfaces, enums) and static-class method delegation. Hard-tier types (sealed structs, delegates, etc.) raise `SHIM001` warnings with a pointer to `fallout-migrate`.
- **Shim packages publish to GitHub Packages** (#47): `Nuke.*` package IDs belong to matkoch on nuget.org, so the transition shim feed lives at GH Packages (`https://nuget.pkg.github.com/ChrisonSimtian/index.json`). Production-build feed is nuget.org with `Fallout.*` only.
- **Shim packages publish to GitHub Packages** (#47): `Nuke.*` package IDs belong to matkoch on nuget.org, so the transition shim feed lives at GH Packages (`https://nuget.pkg.github.com/Fallout-build/index.json`). Production-build feed is nuget.org with `Fallout.*` only.

### Vendored fork of `Microsoft.VisualStudio.SolutionPersistence`
- **Replaced `matkoch.Microsoft.VisualStudio.SolutionPersistence` with a vendored fork** (#86). The upstream Microsoft package only ships `net472` + `net8.0`; our source generators need `netstandard2.0`. Matt's fork had the netstandard2.0 patches — we forked his repo at [`ChrisonSimtian/vs-solutionpersistence`](https://github.com/ChrisonSimtian/vs-solutionpersistence) (preserves the MIT license + upstream Microsoft history + attribution chain). Sources are a submodule at `vendor/vs-solutionpersistence/`; wrapper csproj at `src/Fallout.VisualStudio.SolutionPersistence/` compiles them with the TFMs we need. Assembly name stays `Microsoft.VisualStudio.SolutionPersistence` so type identity is preserved. (Note: in 10.2 the wrapper packed as `IsPackable=false` and caused the restore bug fixed in 10.3.0 above — known issue, fix-forward.)
Expand Down
2 changes: 1 addition & 1 deletion build/Build.cs
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ from framework in project.GetTargetFrameworks()
new PublishTarget
{
Name = "github-packages",
Source = "https://nuget.pkg.github.com/ChrisonSimtian/index.json",
Source = "https://nuget.pkg.github.com/Fallout-build/index.json",
ApiKey = From<ICreateGitHubRelease>().GitHubToken,
},
new PublishTarget
Expand Down
2 changes: 1 addition & 1 deletion docs/agents/release-and-versioning.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ If you only discover the breaking nature mid-review, apply all relevant steps be
| Job | Environment | Fires on tag push? | What ships | Gating |
|---|---|---|---|---|
| `publish-nuget-org` | `nuget-org` | **No — opt-in only** via `workflow_dispatch` flag | `Fallout.*.nupkg` to https://api.nuget.org/v3/index.json | Workflow flag + approval-gated env |
| `publish-github-packages` | `github-packages` | Yes | **All** `*.nupkg` (Fallout.* + Nuke.*) to https://nuget.pkg.github.com/ChrisonSimtian/index.json | None |
| `publish-github-packages` | `github-packages` | Yes | **All** `*.nupkg` (Fallout.* + Nuke.*) to https://nuget.pkg.github.com/Fallout-build/index.json | None |
| `publish-github-releases` | `github-releases` | Yes | All `*.nupkg` attached to a GitHub Release on the tag, auto-generated notes | None |

### Test lanes (from `experimental` and `main`)
Expand Down
2 changes: 1 addition & 1 deletion docs/migration/from-nuke.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ The shim ships on **GitHub Packages** (not nuget.org — that namespace belongs
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<add key="fallout-shims" value="https://nuget.pkg.github.com/ChrisonSimtian/index.json" />
<add key="fallout-shims" value="https://nuget.pkg.github.com/Fallout-build/index.json" />
</packageSources>
<packageSourceCredentials>
<fallout-shims>
Expand Down
2 changes: 1 addition & 1 deletion src/Shims/Nuke.Build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Coverage and limitations are the same as the `Nuke.Common` shim — see [`../Nuk
Add this fork's GitHub Packages feed to your `nuget.config`:

```xml
<add key="fallout-shims" value="https://nuget.pkg.github.com/ChrisonSimtian/index.json" />
<add key="fallout-shims" value="https://nuget.pkg.github.com/Fallout-build/index.json" />
```

Then bump your `Nuke.Build` package reference to the latest 10.3.x or later.
Expand Down
4 changes: 2 additions & 2 deletions src/Shims/Nuke.Common/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@ Until automated dual-publish lands (tracked in [#69](https://github.com/ChrisonS
dotnet pack src/Shims/Nuke.Common/Nuke.Common.csproj -c Release
dotnet nuget push **/Nuke.Common.*.nupkg `
--api-key $env:GITHUB_TOKEN `
--source https://nuget.pkg.github.com/ChrisonSimtian/index.json
--source https://nuget.pkg.github.com/Fallout-build/index.json
```

## Migration path

For projects that just want their `class Build : NukeBuild { ... }` to compile against our framework:

1. Add `https://nuget.pkg.github.com/ChrisonSimtian/index.json` as a NuGet source (`nuget.config`).
1. Add `https://nuget.pkg.github.com/Fallout-build/index.json` as a NuGet source (`nuget.config`).
2. Bump the `Nuke.Common` package version to the latest published here.
3. Build. If the shim covers what you use, you're done. Otherwise:
4. Run `fallout-migrate` to rewrite the remaining references.
Expand Down
2 changes: 1 addition & 1 deletion src/Shims/Nuke.Components/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Limitations are the same as the `Nuke.Common` shim — see [`../Nuke.Common/READ
Add this fork's GitHub Packages feed to your `nuget.config`:

```xml
<add key="fallout-shims" value="https://nuget.pkg.github.com/ChrisonSimtian/index.json" />
<add key="fallout-shims" value="https://nuget.pkg.github.com/Fallout-build/index.json" />
```

Then bump your `Nuke.Components` package reference to the latest 10.3.x or later.
Expand Down
Loading