Add Building section explaining submodule and build commands#230
Closed
dennisdoomen wants to merge 1 commit into
Closed
Add Building section explaining submodule and build commands#230dennisdoomen wants to merge 1 commit into
dennisdoomen wants to merge 1 commit into
Conversation
dennisdoomen
changed the title
ChrisonSimtian
added
the
documentation
ChrisonSimtian
self-requested a review
May 27, 2026 21:23
Collaborator
|
thanks for adding that in :-) This particular one is probably something that should at some point become part of this project because Microsoft wont be maintaining this library in a way its helpful to us. Might as well move forward, write our own SLNX parser and dunno maybe drag along the SLN one until this format dies? (one day .... together with windows forms and VB :D ) |
3 tasks
ChrisonSimtian
added a commit
that referenced
this pull request
May 27, 2026
…/tests (#232) * chore(repo): add CODEOWNERS pointing to @ChrisonSimtian Prep for tightening main branch protection now that external contributors are opening PRs (dennisdoomen, #222 / #230). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(repo): scope CODEOWNERS to /src and /tests only Docs, build orchestrator, CI workflows, and root config remain unowned. The follow-up branch-protection update will pair this with required_approving_review_count=0 + require_code_owner_reviews=true, so docs PRs need only CI green while src/tests PRs require explicit owner approval. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
docs/building-section-submodule
branch
from
May 28, 2026 03:01
2956691 to
639eaa2
Compare
Collaborator
|
I just replaced the submodule with an inhouse solution, so that part can probably drop off |
The vendor/vs-solutionpersistence submodule must be initialised before building. Add a Building section to README.md that covers: - the git submodule init requirement and the two ways to fetch it - the build.ps1 / build.sh entry points and common targets Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dennisdoomen
force-pushed
the
docs/building-section-submodule
branch
from
May 28, 2026 09:47
639eaa2 to
2265dc6
Compare
Collaborator
Author
|
Ah, then we can close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Building section to
README.mdthat explains:vendor/vs-solutionpersistence) that must be initialised before building — without itFallout.VisualStudio.SolutionPersistencefails with a missing.resxerror.git submodule update --init) and how to pull it in one step when cloning fresh (git clone --recurse-submodules).build.ps1/build.shentry points and the most common targets (Compile,Test,--help).Also adds Building to the Table of Contents.