chore: remove AppVeyor-era orphan code#22
Merged
Conversation
These files were dead the moment AppVeyor came out of the pipeline, just nobody noticed because they compiled clean. Sweeping them out so Build.cs is honest about what we actually run. Files removed: - build/Build.Announce.cs — Twitter/Slack/Discord/Mastodon announcement targets. All four had .Requires(secret) on values that only AppVeyor was wired to inject. Dead in trunk. - build/Build.SignPackages.cs — ISignPackages base hardcodes .OnlyWhenStatic(() => AppVeyor != null) in Nuke.Components, so the target permanently skips. Our override was a no-op. - build/Build.ReleaseImage.cs — generated a release-announcement PNG consumed only by Announce. Orphan once Announce is gone. - build/AwtrixNotificationsAttribute.cs — MQTT-driven LED-display notifier for an "Awtrix" IoT device (personal hardware setup of the previous maintainer). Not applied anywhere in this codebase. - build/Build.CustomNaming.cs — emoji-prefix dictionary used only by the deleted TeamCity/AzurePipelines configuration subclasses. Build.cs changes: - Drop `IHazTwitterCredentials` from the partial-class inheritance list and the matching `TwitterCredentials` property. build/_build.csproj package drops (used only by the removed files): - linqtotwitter - MQTTnet - SixLabors.ImageSharp.Drawing Build verified clean (0 errors, 0 warnings). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
Every PR was firing ubuntu-latest twice — once for the push event, once for the pull_request event — because GitHub fires both for same-repo branch pushes with an open PR. Doubling CI runtime and credits for no extra signal. Keeping pull_request only: - Fork PRs continue to trigger (pull_request fires from forks; push doesn't go to the parent repo). - paths-ignore semantics work naturally on pull_request (they were already a no-op for the push trigger). - Pushes to a feature branch without an open PR no longer trigger CI. In trunk-based that's fine — the PR is the work unit. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These five files were dead the moment AppVeyor came out of the pipeline — they just compiled clean, so nobody noticed. Sweeping them out so `Build.cs` reflects what we actually run.
Files removed
Build.cs
Package drops (`build/_build.csproj`)
Used only by the removed files:
Test plan
🤖 Generated with Claude Code