Skip to content

Use PETSc CTX for SNES solver#4139

Open
jorgensd wants to merge 5 commits intomainfrom
dokken/blocked-snes
Open

Use PETSc CTX for SNES solver#4139
jorgensd wants to merge 5 commits intomainfrom
dokken/blocked-snes

Conversation

@jorgensd
Copy link
Copy Markdown
Member

Spawned by the discussion in https://gitlab.com/petsc/petsc/-/work_items/1883.
This is a better way to pass around the _blocks value if required (at least more PETSc like).
Maybe @dalcinl can comment on if this is better than our current approach.

@jorgensd jorgensd requested review from garth-wells and jhale March 31, 2026 17:48
@jorgensd jorgensd requested a review from schnellerhase March 31, 2026 18:34
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
jorgensd added 2 commits April 1, 2026 13:42
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
@jorgensd jorgensd added the housekeeping Tidying and style improvements label Apr 1, 2026
@dalcinl
Copy link
Copy Markdown

dalcinl commented Apr 3, 2026

Passing extra data via kargs seems reasonable. However, this approach will work as long as the SNES solver is tied to a specific instance of a problem, and not reused for another instance of problem where the kargs would not correspond. From my limited pure-human non-AI-assisted understanding of the code, things seem correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Tidying and style improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants