Pass withOnyx instance props to selectors

[tgolen]

Details

This is needed for threads. See the discussion here

Fixes

$ Expensify/App#18489

Automated Tests

Everything is covered by tests

Linked PRs

@grgia will be implementing this

[PauloGasparSv]

LGTM, left a single comment but NAB IMO

[PauloGasparSv]

LGTM!

[tgolen]

OK, I found with @grgia that we needed to pass the state instead of props, and I also found a spot where I wasn't passing the parameter to the selector properly. I've updated tests and docs

[chiragsalian]

havent tested, LGTM. this will be a nice addition.

[JmillsExpensify]

What's left to merge this one?

[tgolen]

@grgia has been testing this pretty extensively on a local branch. @grgia Do you think it's working as intended or does this need more changes before it can be merged?

[grgia]

@tgolen I wasn't able to get it working on my branch using the selector / props - HOC is here if you want to take a look - Expensify/App#18638

[grgia]

I'm not sure it's working as expected, I only seem to get {isLoading: true} no matter the key/number of onyx connect/prop combo

[tgolen]

One way I tested this to ensure it was working was to edit HeaderView.js and:

1. Remove all keys from withOnyx() config
2. Added this single key in the withOnyx() config

        reports: {
            key: ONYXKEYS.COLLECTION.REPORT,
            selector: (reports, props) => {
                console.log('PROPS', props);
                return props && props.report && _.findWhere(reports, {reportID: props.report.reportID})
            }
        }

3. Verified that I saw it was able to find the report and {loading: false} eventually appeared in the console

[tgolen]

Since this is working with the unit tests and in the real-world, I'm going to go ahead and merge this. Maybe one day I will get the chance to implement it in NewDot