Have Onyx.clear() properly call collection callbacks which use waitForCollectionCallback - #216
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
amyevans
and removed request for
a team
December 14, 2022 16:30
yuwenmemon
previously approved these changes
Dec 14, 2022
yuwenmemon
left a comment
yuwenmemon
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for figuring out this wrinkle!
amyevans
previously approved these changes
Dec 14, 2022
amyevans
left a comment
amyevans
left a comment
Contributor
There was a problem hiding this comment.
NAB: I see there's documentation for notifySubscribersOnNextTick in API.md, is it worth it to add notifyCollectionSubscribersOnNextTick there as well?
Collaborator
Author
|
Sure! I can rebuild the documentation. Updated! There were a few more changes to the documentation that it grabbed which should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes Expensify/App#13584
Automated Tests
Covered in unit tests
Linked PRs
The version will be updated in the PR for Expensify/App#11671