fix: apply resizing fix#47
Merged
Merged
Conversation
8 tasks
Author
|
cc @rezkiy37 |
rezkiy37
suggested changes
Feb 13, 2025
rezkiy37
left a comment
rezkiy37
left a comment
Contributor
There was a problem hiding this comment.
Also, we need to update the example once it is deployed.
| { | ||
| "name": "react-fast-pdf", | ||
| "version": "1.0.25", | ||
| "version": "1.0.26", |
Contributor
There was a problem hiding this comment.
The bot bumps it automatically.
Suggested change
| "version": "1.0.26", |
Author
There was a problem hiding this comment.
strange, it should be already like that on main
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Yes, I see it. What's going on? 😅
rezkiy37
approved these changes
Feb 13, 2025
dangrous
approved these changes
Feb 14, 2025
dangrous
left a comment
dangrous
left a comment
Contributor
There was a problem hiding this comment.
This looks good! What's the process for getting these out? Do I just merge? What do I need to do after? Thanks!
dangrous
reviewed
Feb 14, 2025
|
|
||
| # NPM file created by GitHub actions | ||
| .npmrc | ||
| .idea/ |
Contributor
There was a problem hiding this comment.
NAB - what's this change?
Author
There was a problem hiding this comment.
it's for Webstorm users - to ignore local files that Webstorm creates
sobitneupane
approved these changes
Feb 17, 2025
Author
|
hello! just a friendly bump on this one 😃 |
dangrous
approved these changes
Feb 24, 2025
Contributor
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Implement cache invalidation using react-window's resetAfterIndex API and combining it with another useLayoutEffect in this component - to prevent
topvalue miscalculation for the PageRenderer.Related Issues
Expensify/App#55941
Manual Tests
Screen.Recording.2025-02-13.at.13.48.45.mp4
Linked PRs