add mention user rule#600
Closed
tienifr wants to merge 3 commits into
Closed
Conversation
melvin-bot
Bot
requested review from
roryabraham
and removed request for
a team
6 tasks
Contributor
Author
|
@ArekChr The PR is ready for review. For |
ArekChr
reviewed
Nov 13, 2023
| * @param htmlString | ||
| */ | ||
| htmlToMarkdown(htmlString: string): string; | ||
| htmlToMarkdown(htmlString: string, personalDetails: PersonalDetails): string; |
There was a problem hiding this comment.
It could be treated as metadata, allowing us to pass various data through the second parameter.
E.g.
const metadata = { personalDetails }
htmlToMarkdown(html, metadata)
const metadata = { reportDetails }
htmlToMarkdown(html, metadata)
same in htmlToText.
WDYT?
There was a problem hiding this comment.
Should the second parameter be optional?
Suggested change
| htmlToMarkdown(htmlString: string, personalDetails: PersonalDetails): string; | |
| htmlToMarkdown(htmlString: string, personalDetails?: PersonalDetails): string; |
Contributor
Author
|
@ArekChr Thanks for your suggestion, I've updated |
56 tasks
Contributor
|
Looks like we can close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ Expensify/App#29978
Tests
QA
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2023-11-10.at.15.50.29.mov
iOS: mWeb Safari
Screen.Recording.2023-11-10.at.15.34.11.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-10.at.11.56.25.mov
MacOS: Desktop
Screen.Recording.2023-11-10.at.15.42.12.mov