Skip to content

fix: italic syntax removing a preceding character#546

Merged
amyevans merged 4 commits into
Expensify:mainfrom
eh2077:20111-fix-italic-syntax-removing-a-preceding-character
Jun 14, 2023
Merged

fix: italic syntax removing a preceding character#546
amyevans merged 4 commits into
Expensify:mainfrom
eh2077:20111-fix-italic-syntax-removing-a-preceding-character

Conversation

@eh2077

@eh2077 eh2077 commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Fixed Issues

$ Expensify/App#20111

Tests

  1. Go to chat and add a comment
h_ello_
  1. Verify that the comment text is h_ello_ and it's not rendered as italic style.

QA

Same

@eh2077 eh2077 requested a review from a team as a code owner June 12, 2023 16:54
@melvin-bot melvin-bot Bot requested review from marcochavezf and removed request for a team June 12, 2023 16:54
@amyevans amyevans self-requested a review June 12, 2023 17:23
@amyevans

Copy link
Copy Markdown
Contributor

@mollfpr please review

Comment thread lib/ExpensiMark.js Outdated
@mollfpr

mollfpr commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Thanks @amyevans will review it soon!

@marcochavezf marcochavezf removed their request for review June 12, 2023 21:43
@marcochavezf

Copy link
Copy Markdown
Contributor

Removing myself as reviewer, it's weird that PullerBear assigned me 😄

@eh2077 eh2077 requested review from amyevans and mollfpr June 12, 2023 23:57
amyevans
amyevans previously approved these changes Jun 13, 2023
@eh2077 eh2077 changed the title 20111 fix italic syntax removing a preceding character fix: italic syntax removing a preceding character Jun 13, 2023
@eh2077 eh2077 force-pushed the 20111-fix-italic-syntax-removing-a-preceding-character branch from f300d81 to 85df9f8 Compare June 13, 2023 17:50
@eh2077 eh2077 requested a review from amyevans June 13, 2023 17:51

@mollfpr mollfpr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well on my local 👍

cc @amyevans

@amyevans amyevans merged commit 80d0afd into Expensify:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants