Added unescape to htmlToText#538
Merged
srikarparsi merged 2 commits intoMay 18, 2023
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
s77rt
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
_.unescapetohtmlToTextmethod, because we are escaping inreplaceFixed Issues
$ Expensify/App#17658
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
In
Expensimark-test.jsfile, text namedTest text is unescapedWhat tests did you perform that validates your changed worked?
Checked if string is unescaped and character codes are turning back into characters
QA
Run the new test cases
Check if character codes are turned back into charecters in
htmlToTextmethod.&->&